Design #1422
Remove flag IhaveGBasisValue?
Status:
In Progress
Priority:
Normal
Assignee:
Category:
Data Structures
Target version:
Description
As often happens, storing twice an information may lead to problems.
We have the fields IhaveGBasisValue and myGBasisValue.
Currently we cannot have myGBasisValue not empty which is not a valid GBasis.
So, what's the point in having IhaveGBasisValue?
Check well, and decide.
Related issues
History
#1
Updated by Anna Maria Bigatti about 4 years ago
Updated by - Related to Bug #1420: IdealOfProjectivePoints and MinGens: problem with CoCoA_ASSERT added
#2
Updated by Anna Maria Bigatti about 4 years ago
- Related to Design #924: FlagManager for bool/bool3 flags added
#3
Updated by John Abbott about 4 years ago
Updated by Some notes:
- if the ideal is zero then the GBasis is empty (but correct)
- if our impl assumes that non-empty gbasis means that it is correct and complete then this must be clearly documented!
#4
Updated by John Abbott about 4 years ago
- Related to Design #1255: Ideals with trivial GBasis added
#5
Updated by John Abbott about 4 years ago
- Status changed from New to In Progress
IMPORTANT When the task is almost finished, we must review the impl of SparsePolyRingBase::IdealImpl::myGBasis.
#6
Updated by John Abbott over 2 years ago
We should see who uses the flag IHaveGBasis.
Presumably it could be replaced by a function which returns true if the ideal is 0 or if myGBasisValue is not empty.
Is this an issue we can resolve quickly and easily... here "we" probably means Anna ;-)
#7
Updated by Anna Maria Bigatti about 2 years ago
- Target version changed from CoCoALib-0.99800 to CoCoALib-0.99850
#8
Updated by John Abbott 2 months ago
- Target version changed from CoCoALib-0.99850 to CoCoALib-0.99880