Bug #935
ElimMat, ElimHomogMat: complain about zero or negative weights
Description
The fns ElimMat and ElimHomogMat should give error if the user supplies weights are not strictly positive (integers?)
History
#1
Updated by John Abbott over 7 years ago
Updated by It seems that the weights must be integer. This should be documented!
#2
Updated by John Abbott over 6 years ago
- Target version changed from CoCoALib-0.99560 to CoCoALib-0.99600
#3
Updated by John Abbott almost 6 years ago
- Status changed from New to In Progress
- % Done changed from 0 to 10
What is the status of this issue?
What do we allow as "grading matrices"?
Current code requires entries to be integer (but allows matrix over QQ or any ring of char 0?!?)
Should a grading mat with 0 rows be allowed? If so, where?
#4
Updated by John Abbott almost 6 years ago
- Status changed from In Progress to Feedback
- % Done changed from 10 to 90
Anna says that ElimMat should allow a grading mat with 0 rows, but ElimHomogMat should not.
I have adjusted the code accordingly.
#5
Updated by Anna Maria Bigatti over 5 years ago
Updated by - Target version changed from CoCoALib-0.99600 to CoCoALib-0.99650 November 2019
Decide what we really want for these two functions.
They are mostly OK.
#6
Updated by Anna Maria Bigatti over 4 years ago
- Assignee set to Anna Maria Bigatti
- Target version changed from CoCoALib-0.99650 November 2019 to CoCoALib-0.99700
Now I cannot remember WHY they should complain....
postpone to next version
#7
Updated by John Abbott about 4 years ago
- Subject changed from ElimMat, ELimHomogMat: complain about zero or negative weights to ElimMat, ElimHomogMat: complain about zero or negative weights
- Status changed from Feedback to Closed
- % Done changed from 90 to 100
- Estimated time set to 0.99 h
The code calls IsNonNegGrading (see MatrixForOrdering.C around lines 959 and 973).
I presume IsNonNegGrading does a sane check.