Feature #571
CmpAbs for RingElem
Description
We have the fn CmpAbs
for BigInt
and BigRat
.
Mario would like it also for RingElem
(when it is an ordered domain).
History
#1 Updated by John Abbott almost 10 years ago
The current impl works only for int/BigInt. Not for BigRat
#2 Updated by Anna Maria Bigatti almost 10 years ago
Make sense.
We should also do the same (when someone asks ;-) for other functions which can be extended from BigInt to RingElem.
... even though the rule "does on RingElem(ZZ,a) what does on BigInt(a)" cannot be applied in total generality as we chose for different meanings of a/b (but this case would require a Euclidean domain, which is a more complicated structure than an ordered ring)
#3 Updated by John Abbott almost 10 years ago
- Status changed from New to In Progress
- Assignee set to John Abbott
- % Done changed from 0 to 20
- Estimated time set to 4.00 h
I have now checked in an impl for BigRat
.
I have an impl for RingElem
but cannot yet check in (mixed up with other changes)
#4 Updated by John Abbott almost 10 years ago
I have added a test and doc for CmpAbs
for BigRat
#5 Updated by John Abbott almost 10 years ago
- % Done changed from 20 to 50
Implemented & documented; no test yet.
Checked in by commenting out the other changes in ring.C
#6 Updated by John Abbott almost 10 years ago
- Status changed from In Progress to Feedback
- % Done changed from 50 to 90
I have now added a new test, test-RingElem4
, for CmpAbs
of RingElem
. Will check in.
#7 Updated by John Abbott almost 10 years ago
- Status changed from Feedback to Closed
- % Done changed from 90 to 100
No problems have appeared. Closing.