Project

General

Profile

Bug #536

Make RingBase::myCharacteristic a fn rather than a proc

Added by John Abbott almost 10 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Tidying
Target version:
Start date:
15 Apr 2014
Due date:
% Done:

100%

Estimated time:
1.00 h
Spent time:

Description

The mem fn RingBase::myCharacteristic returns void (supposedly for "efficiency", but who's going to calculate millions and millions of characteristics?); make it return the characteristic instead (should be efficient with C++11, if BigInt has a move ctor)

History

#1 Updated by John Abbott over 9 years ago

  • Target version changed from CoCoALib-0.99534 Seoul14 to CoCoALib-1.0

#2 Updated by John Abbott over 2 years ago

  • Assignee set to John Abbott
  • Target version changed from CoCoALib-1.0 to CoCoALib-0.99800

Now we have moved to C++14, and BigInt has a move ctor, we can implement this change.

Should there be a speed check? Maybe it is just better to see if it causes a genuine "slug" at some future point (personally, I doubt it!)

#3 Updated by John Abbott over 2 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

Anna approves too.
Suggestion: create also a fn which returns a machine long (if poss, o/w error).

#4 Updated by John Abbott about 2 years ago

  • Target version changed from CoCoALib-0.99800 to CoCoALib-0.99850

#5 Updated by John Abbott about 1 year ago

  • Status changed from In Progress to Feedback
  • % Done changed from 10 to 90

I have made the change. I really cannot see a sane use-case where characteristic needs to be super efficient.
I have not implemented a variant which returns a machine int -- might this be useful somewhere?

#6 Updated by John Abbott about 1 year ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100

Also available in: Atom PDF