Project

General

Profile

Feature #400

add myJBMill member field to ideal

Added by Anna Maria Bigatti over 10 years ago. Updated over 9 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
New Function
Target version:
Start date:
02 Aug 2013
Due date:
% Done:

0%

Estimated time:
Spent time:

Related issues

Related to CoCoALib - Feature #215: Janet Bases: check and include code in CoCoALib (first prototype)Closed2012-08-02

Related to CoCoALib - Design #455: Which sets of generators in an ideal?New2014-03-03

Related to CoCoALib - Design #871: Redesign idealsNew2016-04-26

Related to CoCoALib - Design #921: Design GBMillNew2016-09-16

History

#1 Updated by Anna Maria Bigatti over 10 years ago

  • Target version set to CoCoALib-0.99532

#2 Updated by Anna Maria Bigatti about 10 years ago

  • Category set to New Function
  • Target version changed from CoCoALib-0.99532 to CoCoALib-0.99533 Easter14

#3 Updated by John Abbott about 10 years ago

  • Target version changed from CoCoALib-0.99533 Easter14 to CoCoALib-0.99534 Seoul14

#4 Updated by Anna Maria Bigatti over 9 years ago

  • Target version changed from CoCoALib-0.99534 Seoul14 to CoCoALib-1.0

#5 Updated by John Abbott over 9 years ago

I found this is an email message (from me) of 20140613:

The (naive) attempt to add a JBMill to an ideal failed dismally :-(
There were several problems:
(1) you cannot have a data member of type std::auto_ptr<JBMill> because
     then the copy ctor won't work;
(2) with C++11 you could use std::shared_ptr instead of auto_ptr...
(3) there were problems with "circular includes": I wanted to add the
      field auto_ptr<JBMill> to IdealImpl in SparsePolyRing.H, but TmpJBMill.H
      already includes SparsePolyRing.H, so the include failed :-(

It might be possible to split SparsePolyRing.H into two files, but I need to
think about this before deciding what to do.

#6 Updated by Anna Maria Bigatti over 9 years ago

John Abbott wrote:

I found this is an email message (from me) of 20140613:
(1) you cannot have a data member of type std::auto_ptr<JBMill> because

then the copy ctor won't work;

(2) with C++11 you could use std::shared_ptr instead of auto_ptr...

SmartPtrIRC

(3) there were problems with "circular includes": I wanted to add the
field auto_ptr<JBMill> to IdealImpl in SparsePolyRing.H, but TmpJBMill.H
already includes SparsePolyRing.H, so the include failed :-(
It might be possible to split SparsePolyRing.H into two files, but I need to
think about this before deciding what to do.

It'd be worth having the implementation of SparsePolyRing::ideal in a separate file.
This data type is crucial in CoCoA and I think it deserves it's own file ;-)

#7 Updated by John Abbott almost 8 years ago

#8 Updated by Anna Maria Bigatti over 7 years ago

Also available in: Atom PDF