Project

General

Profile

Design #339

DenseUPolyClean uses size_t

Added by John Abbott about 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
Portability
Target version:
CoCoALib-0.9953
Start date:
08 Apr 2013
Due date:
% Done:

100%

Estimated time:
Spent time:
1.40 h

Description

DenseUPolyClean uses std::size_t both internally and in fn interfaces.

Is this really appropriate? If not, replace size_t by something else (presumably long).

Related issues

Related to CoCoALib - Feature #219: myDeriv for RingDenseUPolyClean still missingClosed2012-08-03

History

#1 Updated by Anna Maria Bigatti almost 11 years ago

  • Category set to Portability
  • Status changed from New to Feedback
  • Assignee set to John Abbott
  • Target version set to CoCoALib-0.9953
  • % Done changed from 0 to 90

John did this 

// Revision 1.20  2013/04/17 16:30:28  abbott

please set Spent time

#2 Updated by John Abbott almost 11 years ago

Several mem fns have args of type long; should the type be changed to MachineInt?

How many args does deriv have? Header declares 3; impl has only 2. 2 should be enough!

#3 Updated by John Abbott almost 11 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100

In general mem fns will have args f type long (rather than MachineInt) because assume that only "experts" call mem fns.

I have eliminated the deriv signature with 3 args (it corresponded to no impl, and was misleading anyway).

Regarding this matter as closed (even though all the code is rather messy).

Also available in: Atom PDF