Project

General

Profile

Design #308

Error: ERR::NotNonZero instead of ERR::ZeroRingElem? [--> ReqNonZero]

Added by Anna Maria Bigatti over 11 years ago. Updated about 10 hours ago.

Status:
In Progress
Priority:
High
Assignee:
Anna Maria Bigatti
Category:
Renaming
Target version:
CoCoALib-0.99880
Start date:
12 Feb 2013
Due date:
% Done:

40%

Estimated time:
2.00 h
Spent time:
2.35 h

Description

I've found the error ERR::NotNonZero. Should we remove ERR::ZeroRingElem?
(and LogZero, ZeroModulus,..)

Related issues

Related to CoCoALib - Feature #92: Error Codes: BadIndexIn Progress2012-02-14

Related to CoCoALib - Design #427: Error names and error messages (current design)In Progress2014-01-28

History

#1 Updated by John Abbott over 11 years ago

  • Category set to Renaming
  • Status changed from New to In Progress
  • Target version set to CoCoALib-0.9953
  • % Done changed from 0 to 10

The error ZeroRingElem is used for:
StdDeg, LC, Monic, IsIrred, MaxExponent, wdeg (& CmpWDeg & CmpWDegPartial), LF

At the moment I cannot think of a case where it is important to know that the zero value was a ringelem rather than some other type. So I currently am in favour of condensing ZeroRingElem and NotNonZero into a single error.

ChangeLog comments indicate that the error was previously called ZeroPoly.

#2 Updated by John Abbott over 11 years ago

All CoCoALib errors which refer to zero are:
BadPwrZero, DivByZero, LogZero, MemPoolZero, NotNonZero, ZeroModulus, ZeroRingElem

JAA does not like the name NotNonZero, but it is very clear (and no better idea comes to mind).
JAA thinks that LogZero should be merged with NotNonZero.
JAA would like to keep BadPwrZero separate.
JAA thinks that DivByZero and ZeroModulus are closely related, but also thinks they should be kept separate from NotNonZero.
MemPoolZero should really be something like NotPositive (block size).

#3 Updated by Anna Maria Bigatti over 11 years ago

Should we call it ZeroValue instead of NotNonZero?
And NegativeValue instead of NotNonNegative?

#4 Updated by Anna Maria Bigatti over 10 years ago

  • Target version changed from CoCoALib-0.9953 to CoCoALib-0.99532

#5 Updated by Anna Maria Bigatti over 10 years ago

  • Target version changed from CoCoALib-0.99532 to CoCoALib-0.99533 Easter14

#6 Updated by John Abbott about 10 years ago

  • Target version changed from CoCoALib-0.99533 Easter14 to CoCoALib-0.99534 Seoul14

#7 Updated by John Abbott almost 10 years ago

This task is really already covered by the proposed radical restructuring and renaming of the error codes #427. As a consequence, I suggest closing this issue.

#8 Updated by Anna Maria Bigatti almost 10 years ago

  • % Done changed from 10 to 40
  • Estimated time set to 2.00 h

Well, this is actually a sub-task.
I think we can make a quick decision about the names (we have already talked about it), make the change and actually close it.
Anyway now I prefer ExpectNonZero.

#9 Updated by John Abbott almost 10 years ago

Here are some other candidate names:
RequireNonZero
ReqNonZero
NeedNonZero
MustBeNonZero
WantNonZero

#10 Updated by Anna Maria Bigatti almost 10 years ago

WantNonZero or
ExpectNonZero

#11 Updated by John Abbott almost 10 years ago

Of those two I have a preference for WantNonZero -- I can "say" it more easily in my mind than ExpectNonZero.

Christof expressed a mild preference for ExpectNonZero.

#12 Updated by Anna Maria Bigatti almost 10 years ago

John Abbott wrote:

Of those two I have a preference for WantNonZero -- I can "say" it more easily in my mind than ExpectNonZero.

Christof expressed a mild preference for ExpectNonZero.

WantNotZero is shorter, so let's go for it!
I'll implement it: after all the exams I cannot face anything requiring more attention ;-)

#13 Updated by John Abbott almost 10 years ago

  • Target version changed from CoCoALib-0.99534 Seoul14 to CoCoALib-1.0

#14 Updated by Anna Maria Bigatti 3 months ago

  • Priority changed from Normal to High
  • Target version changed from CoCoALib-1.0 to CoCoALib-0.99880

#15 Updated by Anna Maria Bigatti about 16 hours ago

  • Subject changed from Error: ERR::NotNonZero instead of ERR::ZeroRingElem? to Error: ERR::NotNonZero instead of ERR::ZeroRingElem? [--> ReqNonZero]
  • Assignee set to Anna Maria Bigatti

The current decision is for ReqNonZero.
Moreover, similarly as BadIndex, I suggest grouping the similar errors alphabetically as ReqNonZeroBlah: e.g. ReqNonZeroRingElem.

#16 Updated by Anna Maria Bigatti about 16 hours ago

John Abbott wrote:

All CoCoALib errors which refer to zero are:
BadPwrZero, DivByZero, LogZero, MemPoolZero, NotNonZero, ZeroModulus, ZeroRingElem

JAA thinks that LogZero should be merged with NotNonZero.
JAA would like to keep BadPwrZero separate.
JAA thinks that DivByZero and ZeroModulus are closely related, but also thinks they should be kept separate from NotNonZero.
MemPoolZero should really be something like NotPositive (block size).

I modified some:
ZeroModulus, ZeroRingElem, ZeroGradingDim

#17 Updated by Anna Maria Bigatti about 10 hours ago

JAA thinks that LogZero should be merged with NotNonZero.

done

Also available in: Atom PDF