Project

General

Profile

Bug #1565

IsInRadical: gives "weird" error

Added by John Abbott over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Maths Bugs
Target version:
Start date:
19 Jan 2021
Due date:
% Done:

100%

Estimated time:
2.51 h
Spent time:

Description

Specific example:

/**/ I := ideal(x^2,x-x);
/**/ IsInRadical(x,I);
--> ERROR: Value must be non-zero
--> [CoCoALib] SqFreeFactor

Probably caused by zero generator.


Related issues

Related to CoCoALib - Slug #1569: IsInRadical too slow (test-RadicalMembership)Closed2021-01-22

Related to CoCoA-5 - Bug #1610: IsInRadical: some more little bugsClosed2021-09-27

History

#1 Updated by John Abbott over 3 years ago

Also get:

/**/ I := ideal(x-x);
/**/ IsInRadical(x,I);
--> ERROR: Value must be non-zero
--> [CoCoALib] SqFreeFactor

Not sure we want to change this: I was just a bit surprised that the int was not automaically promoted to RINGELEM

/**/ IsInRadical(0,J);
--> ERROR: Expecting type RINGELEM or IDEAL, but found type INT
--> IsInRadical(0,J);

#2 Updated by John Abbott over 3 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 50

I have modified RadicalHelpers in SparsePolyOps-RadicalMembership.C

Seems Ok now. Still testing.

#3 Updated by John Abbott over 3 years ago

  • Status changed from In Progress to Feedback
  • Assignee set to John Abbott
  • % Done changed from 50 to 90

I have modified the code so that it avoid recomputing the "radical helpers".
All tests pass. Will clean and then check in.

#4 Updated by John Abbott over 3 years ago

  • Related to Slug #1569: IsInRadical too slow (test-RadicalMembership) added

#5 Updated by John Abbott over 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100
  • Estimated time set to 2.51 h

Deleted the comment out cruft. There is already a test in ex-bugs.C

Closing!

#6 Updated by Anna Maria Bigatti over 2 years ago

  • Related to Bug #1610: IsInRadical: some more little bugs added

Also available in: Atom PDF