Project

General

Profile

Design #1184

should BeginIter(RingElem) be in SparsePolyIter or in SparsePolyOps-RingElem?

Added by Anna Maria Bigatti almost 6 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
Tidying
Target version:
CoCoALib-0.99700
Start date:
18 May 2018
Due date:
% Done:

100%

Estimated time:
1.01 h
Spent time:
0.80 h

Related issues

Related to CoCoALib - Design #1177: File names: use "SparsePolyOps" prefix for pertinent filesClosed2018-04-06

Related to CoCoALib - Design #1163: Split SparsePolyRing.C in smaller filesClosed2018-02-27

History

#1 Updated by Anna Maria Bigatti over 5 years ago

I think it should be in SparsePolyIter

#2 Updated by Anna Maria Bigatti over 5 years ago

  • % Done changed from 0 to 10

#3 Updated by John Abbott over 5 years ago

I agree that BeginIter should be with the other iterator fns.
Should the file be called SparsePolyOps-iter???

#4 Updated by Anna Maria Bigatti over 5 years ago

  • Status changed from New to Resolved
  • Assignee set to John Abbott

John Abbott wrote:

I agree that BeginIter should be with the other iterator fns.
Should the file be called SparsePolyOps-iter???

I think it is correct SparsePolyIter, the name of the class.
I consider Ops for operations on a certain class (which is defined in its own file)

#5 Updated by Anna Maria Bigatti over 5 years ago

  • Related to Design #1177: File names: use "SparsePolyOps" prefix for pertinent files added

#6 Updated by Anna Maria Bigatti over 5 years ago

  • Related to Design #1163: Split SparsePolyRing.C in smaller files added

#7 Updated by John Abbott over 5 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 10 to 100
  • Estimated time set to 0.66 h

SUMMARY: yes, BigInter goes into the same file where the iterator class is defined

#8 Updated by Anna Maria Bigatti over 5 years ago

  • Status changed from Closed to Resolved
  • Target version changed from CoCoALib-0.99600 to CoCoALib-0.99650 November 2019
  • % Done changed from 100 to 80

After closing this, I changed my mind:
It is simpler to leave the in SparsePolyOps-RingElem.C.
As simple is good, reconsider this for next version, and (probably) reject it.

2020-02 change my mind again! Done it!

#9 Updated by John Abbott over 4 years ago

  • Target version changed from CoCoALib-0.99650 November 2019 to CoCoALib-0.99700

#10 Updated by Anna Maria Bigatti about 4 years ago

I checked. The class declaration is in SparsePolyIter.H.
There are only to functions defined in SparsePolyOps-RingElem.C: BeginIter and EndIter.
Now I think that, even though for just two functions, we should make SparsePolyIter.C and put them there, otherwise it looks akward.

#11 Updated by Anna Maria Bigatti about 4 years ago

  • Status changed from Resolved to Feedback
  • % Done changed from 80 to 90

#12 Updated by Anna Maria Bigatti about 4 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100
  • Estimated time changed from 0.66 h to 1.01 h

Also available in: Atom PDF