Project

General

Profile

Design #1020

Rename minimalized(I) into IdealOfMinGens(I)?

Added by Anna Maria Bigatti about 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Anna Maria Bigatti
Category:
Renaming
Target version:
CoCoA-5.2.2
Start date:
06 Mar 2017
Due date:
% Done:

90%

Estimated time:
1.51 h
Spent time:
1.50 h

Description

I have added IdealOfGBasis(I) to cocoa-5.
It is like saying ideal(GBasis(I)) and SetGBasisAsGens (not available in cocoa-5).

I think the same should be made for IdealOfMinGens(I).
Indeed this already exists: it is called minimalized(I) in cocoa-5.
(not present in cocoalib)

I think IdealOfMinGens(I) is prettier ;-)
Should I add it?
Should minimalized become obsolescent? or should they just coexist?

Related issues

Related to CoCoALib - Feature #957: New function: HasGBasisClosed2016-10-27

Related to CoCoA-5 - Feature #996: New function: IdealOfGBasisClosed2017-01-12

Related to CoCoALib - Feature #1053: New function: IdealOfGBasis, IdealOfMinGens in CoCoALibClosed2017-04-26

Related to CoCoA-5 - Design #1123: Should "minimalize" be obsolescent?Closed2017-11-16

Related to CoCoALib - Feature #1126: New function: SubmoduleOfMinGensClosed2017-11-20

History

#1 Updated by Anna Maria Bigatti about 7 years ago

#2 Updated by Anna Maria Bigatti about 7 years ago

  • Related to Feature #996: New function: IdealOfGBasis added

#3 Updated by John Abbott about 7 years ago

I like IdealOfMinGens.
I do not much like minimalize(I), so suggest making it obsolescent.

Presumably IdealOfMinGens should also copy any 3-way flags from the original ideal? Actually, this is an argument in favour of minimalize :-/

#4 Updated by Anna Maria Bigatti about 7 years ago

John Abbott wrote:

I like IdealOfMinGens.
I do not much like minimalize(I), so suggest making it obsolescent.

good

Presumably IdealOfMinGens should also copy any 3-way flags from the original ideal? Actually, this is an argument in favour of minimalize :-/

I just copied it ;-)

#5 Updated by John Abbott about 7 years ago

  • Status changed from New to In Progress

See also the discussion in issue #996 about which bool3 flags can be (ought to be) copied, and which cannot.

#6 Updated by Anna Maria Bigatti almost 7 years ago

I'm about to make minimalized obsolescent (cocoa and cocoalib).
Should I do the same for minimalize (suggesting "I := IdealOfMinGens(I)")?

#7 Updated by Anna Maria Bigatti almost 7 years ago

  • Target version changed from CoCoA-5.2.0 spring 2017 to CoCoA-5.2.2

Changed my mind :-(
minimalized is also for modules. This needs more thinking.
Postponing to next release.

#8 Updated by Anna Maria Bigatti almost 7 years ago

  • Related to Feature #1053: New function: IdealOfGBasis, IdealOfMinGens in CoCoALib added

#9 Updated by Anna Maria Bigatti over 6 years ago

  • Related to Design #1123: Should "minimalize" be obsolescent? added

#10 Updated by Anna Maria Bigatti over 6 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 50 to 90
  • Estimated time changed from 1.00 h to 1.51 h

Done.
It should also be dome properly for modules, doing in CoCoALib SubmoduleOfGBasis and SubmoduleOfMinGens.

#11 Updated by Anna Maria Bigatti over 6 years ago

  • Related to Feature #1126: New function: SubmoduleOfMinGens added

Also available in: Atom PDF