Design #1409
Updated by John Abbott over 4 years ago
I spent a few hours fixing a bug in
<pre>
bool SparsePolyRingBase::IdealImpl::myTestIsPrimary_0dim() const
</pre>
Now I can claim it was just due to my bad design desing of returning a @bool@: bool:
this way I have actually fooled myself (as author+maintainer) in believing this just returns a @bool@. bool. Instead, the main effect of this function is setting the primary flag.
This is quite common in C++ (changing+returning) but it is more dangerous than useful.
Change this into *@void@*, *void*, test, and fix all its companions.
<pre>
bool SparsePolyRingBase::IdealImpl::myTestIsPrimary_0dim() const
</pre>
Now I can claim it was just due to my bad design desing of returning a @bool@: bool:
this way I have actually fooled myself (as author+maintainer) in believing this just returns a @bool@. bool. Instead, the main effect of this function is setting the primary flag.
This is quite common in C++ (changing+returning) but it is more dangerous than useful.
Change this into *@void@*, *void*, test, and fix all its companions.