Design #581
C++14: MachineInt
Description
We must modify MachineInt when switiching to C++14 because there is a new integral type: (unsigned) long long
Related issues
History
#1
Updated by John Abbott almost 10 years ago
Updated by It might be possible to use templates for the ctors of MachineInt together with a mechanism for ensuring that the actual arg type is integral.
See enable_if (part of C++11, also in BOOST).
Also see http://stackoverflow.com/questions/12073689/c11-template-function-specialization-for-integer-types (the solution by mitchnull).
Also see http://stackoverflow.com/questions/14676574/differences-between-stdis-integer-and-stdis-integral
These last two may allow the same result to be achieved in C++03... not sure though!
#2
Updated by John Abbott almost 10 years ago
- Estimated time set to 5.00 h
#3
Updated by John Abbott about 5 years ago
- Subject changed from C++11: MachineInt to C++14: MachineInt
- Description updated (diff)
- Target version changed from CoCoALib-1.0 to CoCoALib-0.99700
I have modified the subject and description to refer to C++14 instead of C++11.
There is a summary of the integral types available in C++14 at this link:
https://en.cppreference.com/w/cpp/types/integer
Presumably the type intmax_t should be used for the internal representation.
#4
Updated by John Abbott about 5 years ago
- Related to Design #1225: Move to C++14 (skipping C++11) added
#5
Updated by John Abbott about 5 years ago
- Related to Design #925: MachineInt or long for args which are indices (yet again) added
#6
Updated by John Abbott about 5 years ago
- Related to Design #934: MachineInt: change semantics? added
#7
Updated by John Abbott over 4 years ago
- Target version changed from CoCoALib-0.99700 to CoCoALib-0.99800
#8
Updated by John Abbott over 3 years ago
- Target version changed from CoCoALib-0.99800 to CoCoALib-0.99850
#9
Updated by John Abbott about 2 years ago
This is not as straightforward as I was hoping.
It is not hard to change the internal repr (to long long int or even intmax_t).
What is harder is deciding what to do about IsSignedLong, AsSignedLong etc.
I think the GMP interface takes long for machine integers, and there is no interface for long long.
Of course, there should be no problem if long and long long are the same size...
Ummmm!
#10
Updated by John Abbott about 2 years ago
- Status changed from New to Resolved
- Assignee set to John Abbott
- Target version changed from CoCoALib-0.99850 to CoCoALib-0.99800
- % Done changed from 0 to 80
I have modified the impl to use unsigned long long int as the internal repr;
there is also a second impl which uses signed long long int, but that it is not normally used -- have not yet tested it.
Anyway the ULL version seems to work. The main problem will be if ULL and UL are different,
and a caller supplies a value which does not fit into UL. This will likely trigger a run-time
error (ArgTooBig). I'll make a new issue about chasing through all the changes.
#11
Updated by John Abbott about 2 years ago
- Related to Support #1666: MachineInt: chase through ULL changes added
#12
Updated by John Abbott about 2 years ago
- Status changed from Resolved to Closed
- % Done changed from 80 to 100
- Estimated time changed from 5.00 h to 4.70 h
I have fixed some minor bugs -- Bruns compiled on some weird platform which highlighted them.
Checked in. Hoping it is all OK now.