Project

General

Profile

Design #560

CoCoALib/io.H

Added by John Abbott almost 10 years ago. Updated almost 10 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
Tidying
Target version:
CoCoALib-0.99533 Easter14
Start date:
14 May 2014
Due date:
% Done:

100%

Estimated time:
1.00 h
Spent time:
1.25 h

Description

Is the fn InputFailCheck useful at all?

Would it not be clearer to write explicitly:

if (!cin) CoCoA_ERROR(ERR::InputFail, "func name");

Related issues

Related to CoCoALib - Design #535: IO: move GlobalInput etc to CoCoA server!Closed2014-04-11

History

#1 Updated by John Abbott almost 10 years ago

  • Status changed from New to In Progress
  • Assignee set to John Abbott
  • % Done changed from 0 to 40

I have spoken to Anna about this, and she agrees that InputFailCheck contributes essentially nothing, so we may as well eliminate it.

NOTE
  • it was used in BenchmarkToolkit -- I have replaced it by if (!cin) ...
  • it is used extensively in server/CoCoA4io.C, so I have placed InputFailCheck in server/GlobalIO

#2 Updated by John Abbott almost 10 years ago

  • Status changed from In Progress to Closed
  • Target version changed from CoCoALib-0.99534 Seoul14 to CoCoALib-0.99533 Easter14
  • % Done changed from 40 to 100
  • Estimated time set to 1.00 h

I have completed all changes (incl. revised doc/examples).
Everything compiles and runs fine; checked in, so closing.

Also available in: Atom PDF