Project

General

Profile

Design #551

Reconsider overloaded virtual mem fns

Added by John Abbott almost 10 years ago. Updated almost 10 years ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Safety
Target version:
CoCoALib-1.0
Start date:
09 May 2014
Due date:
% Done:

0%

Estimated time:
15.00 h
Spent time:
0.25 h

Description

The warning flag about -Woverloaded-virtual suggests that it may be better to avoid overloading virtual fns, i.e. better to have different names.

Consider this; and decide what to do. There are several contexts: RingBase, PPMonoidBase, PolyRingBase; also in AST.H and Interpreter.H.

Related issues

Related to CoCoA-5 - Bug #545: Compiler g++ 4.2.1 (clang-503.0.40) on MacOSX 10.9: warnings and errorsClosed2014-04-30

History

#1 Updated by John Abbott almost 10 years ago

Just a hint to find easily those bits of code which need to be reviewed: look for using (without std) inside the C++ source files.

Any idea what Scott Meyers says about overloading virtual fns?

#2 Updated by John Abbott almost 10 years ago

  • Target version changed from CoCoALib-0.99534 Seoul14 to CoCoALib-1.0

Also available in: Atom PDF