Project

General

Profile

Bug #54

Bug #53: MSVC10 compilation

MSVC10 - #include <iterator>

Added by Anna Maria Bigatti over 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Category:
Portability
Target version:
Start date:
07 Dec 2011
Due date:
% Done:

100%

Estimated time:
4.00 h
Spent time:

Description

In many files it complains for missing
#include <iterator>
is that right?

History

#1 Updated by Anna Maria Bigatti over 12 years ago

  • Category set to Portability

#2 Updated by Anna Maria Bigatti over 12 years ago

  • % Done changed from 0 to 30

#3 Updated by Anna Maria Bigatti over 12 years ago

  • Subject changed from MSVC10 compilation: #include <iterator> to MSVC10 - #include <iterator>

#4 Updated by Anna Maria Bigatti about 12 years ago

  • Target version set to CoCoA-5.0.2

#5 Updated by John Abbott about 12 years ago

The files which needed <iterator> to be included all seem to need it simply to define the template class back_inserter.

We looked at RingZ.C in detail, and following advice from Scott Meyers's "Effective STL" (section 5, page 26 in our copy), we replaced a call of the form copy(... back_inserter(...)) by a call to a range insert member function. This might also make the code slightly faster.

The new RingZ.C has been checked on MSW, and works. It has been added to CVS.
Anna will check/modify the other files.

#6 Updated by John Abbott about 12 years ago

The use of back_inserter in the header file apply.H could not be replaced by a call to a range insert member function. So we have added an explicit include directive for <iterator>.

#7 Updated by Anna Maria Bigatti about 12 years ago

  • % Done changed from 30 to 90

#8 Updated by Anna Maria Bigatti almost 12 years ago

  • Estimated time set to 4.00 h

#9 Updated by John Abbott almost 12 years ago

  • Status changed from New to Closed
  • % Done changed from 90 to 100

Added include directives for iterator in the cases where it was needed.

Also available in: Atom PDF