Feature #372
add IsFactorClosed
History
#1
Updated by John Abbott almost 11 years ago
Updated by - Category set to CoCoA-5 function: new
- Status changed from New to Feedback
- % Done changed from 10 to 90
Added a reasonable impl of IsFactorClosed to the package monomial_ideals.cpkg5.
Added doc to CoCoAManual.
#2
Updated by John Abbott about 10 years ago
The impl is quite short; move it to C++ (might even be faster?)
#3
Updated by John Abbott about 10 years ago
Implemented in C++ (inside PPMonoid.H and PPMonoid.C); it is faster.
Documented.
Also available in C5 now -- removed impl from monomial_ideals.cpkg5
#4
Updated by Anna Maria Bigatti about 10 years ago
Updated by In the manual we can have
/**/ IsFactorClosed([1, x, x^2]);
(instead of
one(P)) ok ok I'll write the documentation for BuiltInFunctions
There is a problem for
/**/ IsFactorClosed([]);
#5
Updated by John Abbott about 10 years ago
Hey! Have you been talking to Elisa Businelli again?
Fixed the case of an empty list -- it gives true (same as the C++ version), is that correct?
[will check in asap]
#6
Updated by John Abbott about 10 years ago
Now I'm unsure whether IsFactorClosed([]) should return true or give error.
This morning I'm more inclined to favour an error: when could it ever be useful to apply IsFactorClosed to an empty list?
Comments? Opinions? Ideas?
I've also fixed IsFactorClosed([1]) which always gives true (even if no polynomial ring has yet been created).
#7
Updated by John Abbott about 10 years ago
After talking to Anna about my doubt, we have decided that an empty list in input should produce an error (as it seems quite unlikely that someone really would want to test an empty list for being factor closed).
Also modified the CoCoALib impl, and the doc.
#8
Updated by Anna Maria Bigatti about 10 years ago
- Status changed from Feedback to Closed
- % Done changed from 90 to 100
no more problems have arisen. closing.