Project

General

Profile

Bug #280

EmacsUI: indentation is wrong with parentheses

Added by Anna Maria Bigatti over 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
EmacsUI
Target version:
CoCoA-5.0.3
Start date:
29 Nov 2012
Due date:
% Done:

100%

Estimated time:
Spent time:
4.65 h

Description

cocoa5-mode indents wrongly withing parentheses (and one student got worried ;-)

M := F(K, (1,
       2));

This is because pascal-mode (the original source for cocoa(5)-mode), indents that way.
.... where to copy the "correct" code?

History

#1 Updated by John Abbott over 11 years ago

I have had a quick look at the Emacs LISP source code. It is not terribly readable. I believe the relevant function is cocoa5-calculate-indent (in the file src/CoCoA-5/emacs/cocoa5.el; well, the name is promising. I could probably fix it in half a day, but it's always hard to estimate how long it'll take to correct undocumented code written by an unknown person...

#2 Updated by John Abbott over 11 years ago

I believe the Emacs code for C/C++ is in cc-mode.el. On my computer the full path is:
/usr/share/emacs/22.1/lisp/progmodes/cc-mode.el.gz

#3 Updated by John Abbott over 11 years ago

I believe the problem is in lines 697-698 when the value for par is computed.
It is not clear to me how the value of par is used later. As far as I can tell the call to scan-lists produces the "wrong" answer; but playing with the args to scan-lists just produced errors.

Manually setting the value of par to the correct value produces the desired behaviour in emacs.

I would have thought that calling (backward-up-list) instead of (goto-char (scan-lists ...)) would achieve the desired result, but it does not. Emacs reports Expression ends prematurely... Puzzled!

#4 Updated by Anna Maria Bigatti over 11 years ago

  • Status changed from New to Feedback
  • Assignee set to John Abbott
  • % Done changed from 0 to 100

changed relevant code in cocoa5.el into

             ((> (car state) 0)
;;              (goto-char (scan-lists (point) -1 (car state)))
              (backward-up-list)
              (setq par (1+ (current-column)))
              (throw 'nesting 'contexp)
              )

this way it ignores the following code which was confused by the unbalanced parentheses.
We are interested only in indenting the open parentheses: I wonder why pascal-mode doesn't...

#5 Updated by Anna Maria Bigatti about 11 years ago

  • Target version changed from CoCoA-5.0.9 to CoCoA-5.0.3

#6 Updated by John Abbott almost 11 years ago

  • Status changed from Feedback to Closed

There has been no negative feedback in 3 months, so I'm closing this issue.

Also available in: Atom PDF