Bug #238
Cleaner CVS?
Description
(essentially all generated files should not be in the repository)
- the dependency files for
make
- the html documentation, also PDF
- possibly
library.H
- and some files in
src/CoCoA-5/
such asC5.pro
andC5.app
In compensation, we can add a target to the top Makefile
which builds all files which should be in a "tar-ball" for public release; it could also build the tar-ball itself!
Related issues
History
#1 Updated by Anna Maria Bigatti over 11 years ago
John Abbott wrote:
Christof suggests making a cleaner CVS repository:
(essentially all generated files should not be in the repository)
- the dependency files for
make
- the html documentation, also PDF
- possibly
library.H
- and some files in
src/CoCoA-5/
such asC5.pro
andC5.app
I thought we had already removed (some of) them
In compensation, we can add a target to the top
Makefile
which builds all files which should be in a "tar-ball" for public release; it could also build the tar-ball itself!
I have a shell script making the tar-ball: I find it more readable that a makefile...
#2 Updated by John Abbott over 11 years ago
Yes, shell scripts are much more readable than Makefile
code. So we arrange for the make
target to call your shell script :-)
#3 Updated by Christof Soeger over 11 years ago
Here is why I think the dependency files and the C5.pro file should not be in there.
1) They are generated automatically, so there is no need.
2) The existing files include information depending on the configuration, for example paths like
/Users/abbott/Work/NORMALIZ/Normaliz-fa48939/libnormaliz/cone.h
So they cannot used by others.
3) They make the diff less clear.
#4 Updated by Christof Soeger about 11 years ago
Another little argument for my point:
make veryclean; cvs up
gives warnings likecvs update: warning: `include/CoCoA/library.H' was lost
U include/CoCoA/library.H
#5 Updated by Christof Soeger almost 11 years ago
Another argument: The CVS merged some Makefile_dependencies and when I then tried to compile I just got
Makefile_dependencies:50: *** missing separator. Stop.
and had do find the directory to delete that file. Even "make dependencies" gave the same error.
#6 Updated by Christof Soeger about 10 years ago
In the CoCoA5 dir also C5Makefile
is created (together with C5.pro) and depend on autoconf.mk
.
So I suggest to remove it from the cvs.
#7 Updated by John Abbott about 10 years ago
JAA has removed all Makefile_dependencies
from CVS.
#8 Updated by Christof Soeger about 10 years ago
It looks much cleaner now.
I'm not sure how the .cvsignore works but maybe you want to add the Makefile_dependencies to it?
#9 Updated by Christof Soeger about 10 years ago
- Status changed from New to Feedback
- % Done changed from 0 to 90
#10 Updated by John Abbott almost 10 years ago
- Category set to Administration
- Assignee set to John Abbott
- Target version set to CoCoA-5.1.0 Easter14
- % Done changed from 90 to 100
Closing.
#11 Updated by John Abbott almost 10 years ago
- Status changed from Feedback to Closed