Project

General

Profile

Slug #1754

IsSqFree poorly implemented

Added by John Abbott 10 months ago. Updated 2 months ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
Improving
Target version:
CoCoALib-0.99850
Start date:
13 Jul 2023
Due date:
% Done:

100%

Estimated time:
2.88 h
Spent time:
2.90 h

Description

I think IsSqFree for integers is probably poorly implemented.
Investigate, and improve.

History

#1 Updated by John Abbott 10 months ago

Ahh! I misread the code. It is not as "stupid" as I thought, but it still needs improvement (for machine integers -- contains useless lines)

#2 Updated by John Abbott 9 months ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

Source code around NumTheory-factor.C:690

#3 Updated by John Abbott 9 months ago

  • % Done changed from 10 to 90

I have improved the code. It is also a bit faster (than 0.99818).
Will check in soon.

#4 Updated by John Abbott 2 months ago

  • Status changed from In Progress to Closed
  • Estimated time set to 2.88 h

#5 Updated by John Abbott 2 months ago

  • % Done changed from 90 to 100

Also available in: Atom PDF