Project

General

Profile

Slug #1506

Remove XMLFileName from Main.C

Added by John Abbott over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Low
Assignee:
John Abbott
Category:
Cleaning
Target version:
CoCoA-5.4.0
Start date:
09 Oct 2020
Due date:
% Done:

100%

Estimated time:
Spent time:
0.45 h

Description

Main.C calls OnLine::XMLFileName, but I think probably should not.

Consider removing the call; and implement if appropriate.

Related issues

Related to CoCoA-5 - Design #1504: OnlineHelp: XMLFileNameClosed2020-10-08

History

#1 Updated by John Abbott over 3 years ago

#2 Updated by John Abbott about 3 years ago

  • Target version changed from CoCoA-5.4.0 to CoCoA-5.4.2

The fn has been renamed to CoCoAManFileName.

Does the original doubt still hold?
It appears to be a hack to stop a warning being printed out if the XML file with the CoCoA online manual is in the directory where the packages are.
Surely this is something we should warn about?!? The manual should not be in that directory.

I suggest that we remove the relevant line (currently Main.C:109, search for CoCoAManFileName).
Any objections? Might this cause trouble for a release?

#3 Updated by John Abbott about 3 years ago

  • Status changed from New to Feedback
  • Assignee set to John Abbott
  • % Done changed from 0 to 90

Anna agrees that the check seems to about something ancient, and should be disable/removed.
Currently comment out -- delete the line (109 in Main.C) before closing!

#4 Updated by Anna Maria Bigatti over 2 years ago

  • Status changed from Feedback to Closed
  • Target version changed from CoCoA-5.4.2 to CoCoA-5.4.0
  • % Done changed from 90 to 100

Also available in: Atom PDF