CoCoA » CoCoA-5

There was not enough time during my visit, so we were unable to look at this. Postponing to next version.

I do not want to lose this, but there is never time... grrr!

I have tried Ulrich's patches and it works!

I did also try switching to std::thread etc. Everything compiled, but C5 would crash instantly.
No idea why, and I don't want to investigate.

Anyway, many thanks to Ulrich! He should register here how much time he spent revitalizing the code.

John Abbott wrote:

I did also try switching to std::thread etc. Everything compiled, but C5 would crash instantly.
No idea why, and I don't want to investigate.

I am attaching a patch with which the GUI works (here...) using std::thread instead of boost::thread.
The crucial part is a call to std::thread::detach(), which is apparently not necessary in the boost version.

Installation of the patch is possible by executing patch -p1 < ../CoCoALib-0.99718_patch_stdthread inside the (Qt5 patched) CoCoALib 0.99718 directory.

I have checked in. Also improved configure (to be more helpful).
Modified some code to eliminate compiler warnings (and asked Bruns to do so too).

Thanks to Ulrich, again!

Ulrich von der Ohe wrote:

It seems that many of the files needed to build the GUI are missing from the CoCoALib 0.99800 release (build system files as well as source files which had all been present in 0.99718).

Therefore the GUI cannot be built from the files provided in CoCoALib 0.99800.

Since many other GUI files still remain in the release and are in fact patched this doesn't seem like it was intended.

For the time being, perhaps the attached shell script is useful. It produces a version of CoCoALib 0.99800 with GUI related files copied over (and patched for Qt5) from 0.99718 from which the Qt5 GUI can be built. See the comment at the beginning of the script for instructions.

Hi John, I attach three files which I think should do the job:

1) qt5check.sh: Checks for qmake, runs it it on qt5check.pro, makes the resulting makefile, and runs the resulting program.
2) qt5check.pro: A qmake project file that depends on the same Qt5 libraries as the CoCoA GUI.
3) qt5check.cpp: A C++ program that prints the Qt5 version number.

The actual check for the libraries is done via qmake and the project file, and we also compile and run a program that uses a Qt5 library function.

Please let me know if this is okay for you (or modify as you wish).

I attach a new version of qt5check.sh. Please use this one instead of the one I uploaded earlier.

For macOS, the qmake options set in src/CoCoA-5/make-c5makefile.sh are more involved than I initially thought and the previous qt5check.sh did not set them correctly (but made the impression to do so).

The new qt5check.sh does NOT attempt to treat macOS differently from other systems, and I presume that this is okay for a simple test whether the libraries exist.

It would be good if someone running macOS could confirm that the script succeeds (with relevant parts of Qt5 installed).

The code in make-c5makefile.sh seems to laboriously determine the architecture of the system (e.g. x86_64) (couldn't one use uname -m for that?) and then to force qmake to build for that architecture.

It might be that the macOS specific stuff in make-c5makefile.sh has by now become obsolete. In this case it would be better to remove it in make-c5makefile.sh than to also clutter qt5check.sh with it.

I attach a revised version of the shell script. It is somewhat modeled after configuration/gmp-check-cxxflags.sh (as you suggested). The .pro and .cpp files are not necessary anymore (now built into the shell script).

Regarding macOS: I don't know if the Qt5 GUI builds or runs on any version of macOS.

I included the qmake flag -spec macx-g++ on macOS as in make-c5makefile.sh and make-qcodeeditmakefile.sh.

I suspect the architecture dependent stuff for macOS in those files is now obsolete. I find the options CONFIG += x86 etc. mentioned explicitly only in Qt4 documentation:
https://doc.qt.io/archives/qt-4.8/deployment-mac.html#architecture-dependencies
but not in later documentation:
https://doc.qt.io/qt-5/macos-deployment.html
(the whole section is gone).

Since checking for the architecture as in make-c5makefile.sh (by compiling another program and then examining the resulting binary) would complicate the check considerably with doubtful benefit, I did not incorporate any of this into qt5-check.sh.

Please let me know if any issues remain (or adapt the script yourself as you see fit).

As a test I built the GUI successfully on OpenBSD.

The process exposed also several several minor issues with the build scripts (at least some of which can also affect other systems). Patches are attached, along with a revised version of qt5-check.sh.

Some or all of these issues may already be fixed in your current development version. Still it would be nice if you could look at these patches and consider merging them, if possible. A changelog is below. Please let me know if anything is unclear or could be done better.

The attached patch file (buildscriptpatches) is intended to be applied to CoCoALib-0.99800 after the GUI has been patched with the patch from #1393#note-15 by running patch -p1 < buildscriptpatches from inside the CoCoALib directory. After applying the patch file, execute permissions to the newly created file configuration/qt5-check.sh must be set.

Alternatively, the attached shell script CoCoALib-0.99800_qt5gui+buildscriptpatches.sh can be used, which incorporates the patch from #1393#note-15, the revised qt5-check.sh and the build script patch.

Changelog (build scripts only):

1. configuration/qt5-check.sh: Revised and integrated (cf. 2, 8, 9).

• Fixes concerning Boost headers and libraries (cf. 3, 4, 7).
• Fixes concerning Readline headers (cf. 3, 5).
• Use configuration/qt5-check.sh (cf. 1).
• Fix concerning fPIC (cf. 6).
• Build GUI by default if sufficient Qt5 system is found.
• New option --no-qt-gui to disable building GUI.
• Removed option --Qt-gui.

• Fixes concerning Boost (cf. 2, 4, 7).
• Fixes concerning Readline.

4. configuration/boost-check-arch.sh: Fixes concerning Boost (cf. 2, 3, 7).

5. configuration/readline-find-hdr.sh: Readline headers were not found on some systems (cf. 2, 3).

• No special treatment of Clang++: Leave out -Wl,-no_pie.
• Integrate the only remaining option into configure (cf. 1).
  [My tests show that -Wl,-no_pie or -Wl,--no-pie each lead to problems
  on some systems (i.e. link time error). Thus, unless there are good
  reasons not to, I would suggest to leave -no_pie and --no-pie out.]

• Fixes concerning Boost libraries (cf. 2, 3 4).
• Pass CXX=$(CXX) to build GUI.
• Using $(MAKE) instead of hard coded make.

8. src/CoCoA-5/make-qcodeeditmakefile.sh: Fixes concerning name of qmake executable (cf. 1, 9).

9. src/CoCoA-5/make-c5makefile.sh: Fixes concerning name of qmake executable (cf. 1, 8).

10. src/CoCoA-5/tests/Makefile: Error messages from RunTests.sh were redirected to /dev/null (cf. 11).

11. src/CoCoA-5/tests/RunTests.sh: Number of tests calculated correctly (cf. 10).

12. doc/Makefile: Fixes concerning txt2tags (cf. #1662).

13. doc/CoCoALib-tasks/Makefile: $(CXX) instead of hard coded g++.

It is still not clear to me what bothers you about the QCodeEdit license. As I said on the phone call you refer to, if you want QCodeEdit under a different license (the reason would not be clear to me at this point), then contacting its author to me seems necessary (and possible).

As I wrote here before, I think that any potential licensing issues should be discussed on their own since they have nothing to do with the issue at hand (the change from Qt4 to Qt5).

I attach a new version (for the time until your next release) of the Qt5 build system patch, fixing an issue when building on systems without Qt5.