Feature #1358: Emacs UI: should active input line be cleared before sending line from CoCoA-5 file? - CoCoA-5 - CoCoA Project

Feature #1358

Emacs UI: should active input line be cleared before sending line from CoCoA-5 file?

Added by John Abbott over 4 years ago. Updated about 4 years ago.

Status:

Closed

Priority:

Normal

Assignee:

John Abbott

Category:

EmacsUI

Target version:

CoCoA-5.3.0

Start date:

30 Oct 2019

Due date:

% Done:

100%

Estimated time:

1.88 h

Spent time:

1.90 h

Description

When using the Emacs UI, possibly confusing problems can arise if the user has started to type some input in the executing cocoa5 window, but does not press enter, then switches to a cocoa5 source file and chooses send-line or source-region or source-file

Do we want to clear the active input line when send-line or source-region or source-file are called?

Discuss, decide, implement.

Related issues

History

#1 Updated by John Abbott over 4 years ago

I think it is probably a good idea to clear the last line (assuming this can be done reasonably easily in emacs).

I have occasionally myself typed something accidentally into the interactive CoCoA-5 buffer (but without hitting return), then switched to another buffer with CoCoA-5 source code, and finally been puzzled as to why a "source" command did not work.

It would be harder to "protect against" a mistake where the user typed in a line with return (but without semicolon); the interpreter will already have received the line, and will be awaiting the end of the command. If we want, we could get some mild protection by sending a semicolon immediately before the source command (not sure if this is really a good idea).

#2 Updated by John Abbott over 4 years ago

Status changed from New to In Progress
% Done changed from 0 to 30

I have a first version which seems to work: after (goto (point-max)) I have inserted (move-beginning-of-line nil) and then (if (not (eq (point) (point-max))) (kill-line)). Note that (kill-line) alone does not work well because it triggers a bell (i.e. error signal) if the line is empty.

A quick test suggests that it works OK. I'll use it for a few days before checking in.

I have not implemented the idea of inserting a semicolon at the start of the line.

NOTE my changes can be found by looking for (goto (point-max)).