Project

General

Profile

Bug #135

Revise interface to SmallFpImpl & friends

Added by John Abbott about 12 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
Tidying
Target version:
CoCoALib-0.9953
Start date:
20 Apr 2012
Due date:
% Done:

100%

Estimated time:
30.00 h
Spent time:
30.20 h

Description

After starting work on the reimplementation of DUPFF in C++, I discovered that the interface to SmallFpImpl is needlessly awkward to use (and not as well documented as I thought).

The interface will be revised in parallel with the reimplementation of DUPFF.

Analogous comments apply to SmallFpLogImpl and SmallFpDoubleImpl.

Related issues

Related to CoCoALib - Feature #127: Convert DUPFF code to C++In Progress2012-04-05

Related to CoCoALib - Design #649: Make SmallFpImpl safer to useClosed2014-11-11

History

#1 Updated by John Abbott almost 12 years ago

  • Estimated time changed from 15.00 h to 30.00 h

Confirmed need for major redesign.

Current main doubt is how public I should be about the type SmallFpImpl::value_t; I would like to say that it is an unsigned integral type -- I don't see how it can be harmful to reveal this much information.

Increased time estimate because the changes will affect 6 files: 3 files SmallFp*impl and 3 files RingFp*. Also need to update the doc and examples (if any?).

#2 Updated by John Abbott almost 12 years ago

Added fns equivalent to many of the procedures for arithmetic.

Needed to add several other fns. Development proceeds in tandem with DUPFF rewrite.

#3 Updated by John Abbott almost 12 years ago

  • Status changed from New to In Progress

#4 Updated by John Abbott over 11 years ago

  • Assignee set to John Abbott
  • % Done changed from 0 to 70
I have made a first revised impl of SmallFpImpl; all tests pass.
Plenty of work still to do:
  • update documentation
  • remove cruft
  • some details of new interface still to be decided
  • more thorough testing
  • check in new code & doc

#5 Updated by John Abbott over 11 years ago

  • Category set to Tidying

All tests passed.
Done a Friday afternoon check-in of current "first revised" version of code.
Also revised doc for SmallFpImpl (but not yet for SmallFpLog or SmallFpDouble).

Note that DUPFp code will need revising!

#6 Updated by John Abbott about 11 years ago

  • Status changed from In Progress to Feedback
  • Target version set to CoCoALib-0.9953
  • % Done changed from 70 to 90

Revised interface now works well in the context of DUPFp.
Updated all 3 impls, and their doc.

Perhaps revise impls of IsGoodArgForCtor to use the new fn ourMaxModulus???

#7 Updated by John Abbott almost 11 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100

Conducted final check ==> some "cosmetic changes".
Added an example program ex-SmallFp1.C

Closing this issue.

Also available in: Atom PDF