Project

General

Profile

Design #1348

cocoa5 script for releases

Added by John Abbott over 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Anna Maria Bigatti
Category:
enhancing/improving
Target version:
CoCoA-5.3.2
Start date:
23 Oct 2019
Due date:
% Done:

100%

Estimated time:
4.99 h
Spent time:
4.94 h

Description

A student today reported a problem with CoCoA-5 on her Mac: we released a "bad" version of the cocoa5 start-up script!

At the moment we have 4 distinct versions of the script for starting CoCoA-5:
  • src/CoCoA/cocoa5 the one that we use
  • src/CoCoA/release-files/cocoa5-linux
  • src/CoCoA/release-files/cocoa5-mac
  • src/CoCoA/release-files/cocoa5-microsoft

The trouble is that (rare) updates to cocoa5 do not pass automatically to the scripts in release-files.

Can we make a better design?

Related issues

Related to CoCoA-5 - Support #1222: Release CoCoA-5.3.0Closed2018-08-28

Related to CoCoA-5 - Design #1352: cocoa5 (launch) script: sleep timeClosed2019-10-25

Related to CoCoA-5 - Feature #1479: CoCoA release for linux: CoCoAInterpreter: with and without libreadline?Closed2020-08-07

History

#1 Updated by John Abbott over 4 years ago

The bug the student had found had been fixed (ages ago?) in our "private" version of cocoa5, but the change was never ported to the versions used for releases. This is bad design on our part :-(

#2 Updated by John Abbott over 4 years ago

I have noticed that cocoa5-linux still includes the trick for choosing between 32-bit and 64-bit executables. Isn't this obsolete now?

I have modified release-linux so that it checks whether cocoa5-linux is newer than src/CoCoA-5/cocoa5; if it is not newer then an error message is printed, and the script exits (with code 1). CVS-ed.

#3 Updated by John Abbott over 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 20

I have updated the release-* scripts for Linux, Mac and Microsoft.
CVS-ed.

#4 Updated by Anna Maria Bigatti over 4 years ago

#5 Updated by Anna Maria Bigatti over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 80

Done, I believe.
Now testing comes.

#6 Updated by Anna Maria Bigatti over 4 years ago

I made a new release for mac and for linux on the webpage.

#7 Updated by Anna Maria Bigatti over 4 years ago

  • Status changed from Resolved to Feedback
  • Assignee set to Anna Maria Bigatti
  • % Done changed from 80 to 90

I recovered the check on 32/64 bits for linux even though we no longer distribute 32-bit.
(but this way the user gets a reasonable error message)

New release made for testing.

#8 Updated by John Abbott over 4 years ago

  • Related to Design #1352: cocoa5 (launch) script: sleep time added

#9 Updated by John Abbott about 4 years ago

  • Estimated time set to 4.90 h

Regarding comment 7: I spotted the code which checked for 64-bit platform, and complained if not.

Now I'm undecided. One the one hand giving a helpful error message is always nice, on the other hand it clutters the code (and I imagine there are very few people with 32-bit linux boxes who download binaries and expect them to work).

My (mild) preference lies with making the cocoa5 script simpler by removing code which is hardly ever useful. Perhaps we could simply state on the download page, that the binary is just for 64-bit platforms?

#10 Updated by John Abbott almost 4 years ago

  • Target version changed from CoCoA-5.3.0 to CoCoA-5.3.2

#11 Updated by John Abbott over 3 years ago

  • Related to Feature #1479: CoCoA release for linux: CoCoAInterpreter: with and without libreadline? added

#12 Updated by John Abbott over 3 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 90 to 100
  • Estimated time changed from 4.90 h to 4.99 h

This was resolved some time ago by including in the release-linux.sh script a check that the start-up script in the released version is at least as new at the script being used by us for development/testing. Simple and effective :-)

Also available in: Atom PDF