Project

General

Profile

Design #1334

sylvester or SylvesterMat?

Added by John Abbott over 4 years ago. Updated about 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
Renaming
Target version:
CoCoA-5.3.0
Start date:
08 Oct 2019
Due date:
% Done:

100%

Estimated time:
2.77 h
Spent time:
2.85 h

Description

CoCoA-5 has a function called sylvester; should it not be called SylvesterMat?

History

#1 Updated by Anna Maria Bigatti over 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

I vote for SylvesterMat

#2 Updated by John Abbott over 4 years ago

This fn should be in CoCoALib!
Move it there and change its name; and put sylvester into obsolescent. Change the doc too!

#3 Updated by Anna Maria Bigatti over 4 years ago

John Abbott wrote:

This fn should be in CoCoALib!
Move it there and change its name; and put sylvester into obsolescent. Change the doc too!

There is some commented out code in MatrixSpecial.C

#4 Updated by John Abbott over 4 years ago

  • Assignee set to John Abbott
  • % Done changed from 10 to 60

I have now made the impl in C++; more or less a straight copy of the CoCoA-5 code.

It seems to work (on 2 simple examples).

Still have to make tests, and update doc.

#5 Updated by John Abbott over 4 years ago

What should SylvesterMat do if one of the args is 0?
An error must be signalled, but how?
Currently the error is from deg which says that a non-zero ringelem is required.
Should the error actually be thrown by SylvesterMat?

#6 Updated by John Abbott over 4 years ago

Not really related: there is a function jacobian which returns the jacobian matrix. Should it be called JacobianMat?

#7 Updated by John Abbott over 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 60 to 80

I have changed the CoCoA-5 manual to use the new name. There was no need to change any tests.

Also added SylvesterMat to CoCoALib doc; no test :-(
Mmm, I wonder how resultant is implemented? 8-{

#8 Updated by Anna Maria Bigatti over 4 years ago

John Abbott wrote:

Not really related: there is a function jacobian which returns the jacobian matrix. Should it be called JacobianMat?

yes!

#9 Updated by John Abbott over 4 years ago

I have renamed jacobian to JacobianMat; jacobian is now in obsolescent (both for CoCoA-5 and CoCoALib).

#10 Updated by John Abbott over 4 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 80 to 100
  • Estimated time set to 2.22 h

There is no test, but otherwise the code looks fine. Closing.

#11 Updated by John Abbott over 4 years ago

  • Estimated time changed from 2.22 h to 2.77 h

Added test to test-MatrixSpecial1.C

#12 Updated by Anna Maria Bigatti about 3 years ago

cocoa5 manual for jacobian updated now (2021-01)

Also available in: Atom PDF