Project

General

Profile

Bug #1273

NewPolyRing and SymbolRange together make a crash

Added by John Abbott almost 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
bug
Target version:
Start date:
29 Apr 2019
Due date:
% Done:

100%

Estimated time:
1.99 h
Spent time:

Description

The problem is with double indices. Here is a small failing example:

vars := SymbolRange("a", [1,2],[1,2]);
P := NewPolyRing(QQ, vars); -->  BOOM!

The output of SymbolRange looks wrong anyway, but it should not cause a crash!

Note: reported by Julian Danner (Passau)


Related issues

Related to CoCoA-5 - Feature #1290: NewPolyRing: allow symbols with just head and no indices?Closed2019-05-27

Related to CoCoA-5 - Bug #1384: NewPolyRing and SymbolRangeClosed2020-01-07

History

#1 Updated by John Abbott almost 5 years ago

The SymbolRange impl looks very suspect. It does not properly check its arg types.

Fn is defd in coclib.cpkg5. Investigating & cleaning.

#2 Updated by John Abbott almost 5 years ago

  • Status changed from New to Resolved
  • Assignee set to John Abbott
  • % Done changed from 0 to 50

One problem appears to be on line 46 of cocolib.cpkg5: replace [i] with just i.

#3 Updated by John Abbott almost 5 years ago

  • % Done changed from 50 to 80

Another problem was in evalArgAsListOfSymbols which did a dynamic pointer cast and used the result without checking whether it was nullptr. Seems better now.

Note: reference Interpreter.C near line 136

#4 Updated by John Abbott almost 5 years ago

  • Description updated (diff)
  • Estimated time set to 1.99 h

I must get my CVS access sorted out, so I can check in.

#5 Updated by John Abbott almost 5 years ago

  • Related to Feature #1290: NewPolyRing: allow symbols with just head and no indices? added

#6 Updated by Anna Maria Bigatti over 4 years ago

Seems to work now, both on Mac and on Linux.
Close?

#7 Updated by John Abbott over 4 years ago

  • Target version changed from CoCoA-5.3.0 to CoCoA-5.4.2
  • % Done changed from 80 to 100

#8 Updated by Anna Maria Bigatti over 4 years ago

  • Target version changed from CoCoA-5.4.2 to CoCoA-5.3.0

#9 Updated by Anna Maria Bigatti about 4 years ago

  • Status changed from Resolved to Closed

#10 Updated by Anna Maria Bigatti about 4 years ago

  • Related to Bug #1384: NewPolyRing and SymbolRange added

Also available in: Atom PDF