Project

General

Profile

Bug #552

C5 BuiltinFunctions.c fn RingElem

Added by John Abbott almost 10 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
High
Assignee:
Category:
Incomplete function
Target version:
Start date:
09 May 2014
Due date:
% Done:

100%

Estimated time:
1.00 h
Spent time:

Description

What is going on in the impl of builtin fn RingElem; source is in BuiltinFunctions.C:949-977???

Something BAD!

History

#1 Updated by John Abbott almost 10 years ago

  • Status changed from New to In Progress
  • Assignee set to John Abbott
  • % Done changed from 0 to 50

OK, I think I have figured out what the code is supposed to do. I've added some documentation (and improved variable names).

At first sight the code looked to be horribly wrong! We definitely need to redesign the way builtin fns are defined!

#2 Updated by John Abbott almost 10 years ago

  • Estimated time set to 1.00 h

Wouldn't it be more natural to specify indexed symbols using this syntax: RingElem(R, "x", [2,3])?

#3 Updated by John Abbott almost 10 years ago

  • % Done changed from 50 to 60

I've tested and checked in my revised impl.
Perhaps I was too paranoid after finding an ugly bug in IsHomog (also fixed).

#4 Updated by John Abbott almost 10 years ago

  • Priority changed from Immediate to High
  • Target version changed from CoCoA-5.1.0 Easter14 to CoCoA-5.1.1 Seoul14

#5 Updated by John Abbott over 9 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 60 to 100

Anna explains that the ugly interface was devised to allow a C5 user to create another poly ring whose indets have the same names as those of an existing ring.

Presumably this can be killed when such a capability becomes available in CoCoALib?

Closing.

Also available in: Atom PDF