Project

General

Profile

Bug #1424

'UNCAUGHT UNKNOWN EXCEPTION' when aborting 'isin' computation

Added by Julian Danner about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
John Abbott
Category:
bug
Target version:
CoCoA-5.3.0
Start date:
25 Feb 2020
Due date:
% Done:

100%

Estimated time:
2.90 h
Spent time:
2.80 h

Description

If you call the 'isin' command and want to abort the computation using <ctrl+c>, CoCoA-5 crashes and outputs: ERROR UNCAUGHT UNKNOWN EXCEPTION.

For example use the following:

Use R::=ZZ/(101)[x,y,z];
I:=ideal([RandomLinearForm(R)^10*(RandomLinearForm(R)+x^2) | i in 1..10]);
f:=RandomLinearForm(R)^2;
f isin I;

If one aborts the computation with <ctrl+c> before it finishes, CoCoA-5 crashes. (Don't be too slow, this example does not give you much time...)

History

#1 Updated by John Abbott about 4 years ago

I confirm the bug in 5.2.9.

#2 Updated by John Abbott about 4 years ago

  • Status changed from New to In Progress
  • % Done changed from 0 to 10

I expect the problem isin Interpreter.C at line 3316 where a CoCoA::ErrorInfo is caught, but InterruptReceived is of type CoCoA::exception.

#3 Updated by John Abbott about 4 years ago

  • Assignee set to John Abbott
  • Target version set to CoCoA-5.3.0
  • % Done changed from 10 to 50

I have fixed the problem, but want to discuss with Anna before checking in.

The problem was indeed where I said, but there is a deeper issue...

#4 Updated by John Abbott about 4 years ago

After looking at the code, I think the same problem exists for modules.

#5 Updated by John Abbott about 4 years ago

Here is a test for both ideals and modules....

Use R::=ZZ/(101)[x,y,z];
g := [RandomLinearForm(R)^13*(RandomLinearForm(R)+x^2) | i in 1..10];
I := ideal(g);
x isin I;   -- interrupt quickly!   RINGELEM isin IDEAL
I := ideal(g);
1 isin I;   -- interrupt quickly!   INT isin IDEAL
I := ideal(g);
1/2 isin I; -- interrupt quickly!  RAT isin IDEAL

// Same but for modules...
F := NewFreeModule(R,1);
S := submodule(F, [ModuleElem(F,[f]) | f in g]);
J := ModuleElem(F, [1]);
J isin S; -- interrupt quickly!

1/101 isin I; --> also caused a crash!

#6 Updated by John Abbott about 4 years ago

The impl in Interpreter.C is not as clear as it could be... The relevant function is in lines 3285--3338
intrusive_ptr<Value> IsInExpression::implEval(RuntimeEnvironment *runtimeEnv) const

It needs to be tidied considerably. :-/

#7 Updated by John Abbott about 4 years ago

  • % Done changed from 50 to 70

I have tidied (incl. indented comprehensibly) the code. I have tested it with the example in comment 5, and all seems well.

NOTE: not sure how we could make an automatic test for this...

#8 Updated by John Abbott about 4 years ago

  • Status changed from In Progress to Resolved
  • % Done changed from 70 to 80
  • Estimated time set to 2.50 h

I have checked all uses of ErrorInfo in Interpreter.C (and changed some indentation). It seems OK now.
Added another failing case to the test in comment 5.

#9 Updated by John Abbott about 4 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 80 to 100
  • Estimated time changed from 2.50 h to 2.90 h

Anna has checked everything on her computer. Works fine.
Closing.

Also available in: Atom PDF