Project

General

Profile

Bug #1224

Lexer: unclosed multi-line comment

Added by John Abbott over 5 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Low
Assignee:
John Abbott
Category:
Cleaning
Target version:
CoCoA-5.3.0
Start date:
04 Sep 2018
Due date:
% Done:

100%

Estimated time:
0.75 h
Spent time:
0.70 h

Description

The lexer supposedly handles unclosed multi-line comments (at the end of input).
However, it seems that the error message wants to print out the character where the problem was, but this char is EOF (or maybe EOL).

Also the Emacs interface gets confused, and everything is printed in comment colour (yellow in my case)

History

#1 Updated by John Abbott about 4 years ago

  • Assignee set to John Abbott
  • Target version changed from CoCoA-5.?.? to CoCoA-5.3.0
  • % Done changed from 0 to 50

Is this still a problem?

I do not observe now the problem about everything staying in "comment colour".

The error message tries to be helpful by indicating start and end of the problem; I now think that what it prints is acceptable, maybe we could try to be cleverer about the arrows marking the end of input (but the message itself does say that the comment is unclosed).

I suggest closing this issue.

#2 Updated by John Abbott about 4 years ago

  • Status changed from New to Resolved
  • % Done changed from 50 to 80

Surely the unfinished multi-line comment can occur only at the end of the input, so the "end marker" always has to be EOF.

I think we can mark this as satisfactorily solved. OK?

#3 Updated by John Abbott about 4 years ago

  • Description updated (diff)

#4 Updated by John Abbott about 4 years ago

  • Status changed from Resolved to Closed
  • % Done changed from 80 to 100
  • Estimated time set to 0.75 h

Some quick tests pass fine. Not worth investing more time here.
Closing.

Also available in: Atom PDF